Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: participants and screen sharing tracking in call end analytics - WPB-12199 #2382

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 13, 2025

StoryWPB-12199 [iOS] Call end - Event and segmentation

Issue

Currently there was an error in the implementation and neither the call participant count nor the screen sharing tracking worked properly.
This PR intents to fix it.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 13, 2025
Copy link
Contributor

Test Results

    1 files      2 suites   2m 21s ⏱️
1 793 tests 1 767 ✅ 26 💤 0 ❌
1 803 runs  1 777 ✅ 26 💤 0 ❌

Results for commit 439b896.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/call-end-analytics-WPB-12199
Commit report: 44dfdfa
Test service: wire-ios-mono

✅ 0 Failed, 1689 Passed, 26 Skipped, 2m 21.71s Total Time

@caldrian caldrian requested review from netbe and johnxnguyen January 13, 2025 12:22
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, should we add a testcase to cover the changes?

@caldrian caldrian added this pull request to the merge queue Jan 16, 2025
Merged via the queue into develop with commit fb6b8a1 Jan 16, 2025
15 checks passed
@caldrian caldrian deleted the fix/call-end-analytics-WPB-12199 branch January 16, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants