-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create authentication identity input view - WPB-15221 #2343
Conversation
Test Results 1 files 10 suites 27s ⏱️ Results for commit b050b89. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ❌ 2 Failed (0 Known Flaky), 76 Passed, 1 Skipped, 1m 26.06s Total Time ❌ Failed Tests (2)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a snapshot test like SidebarMenuItemSnapshotTests
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would have this PR targeting develop
and additionally ensure that all strings are localized. That way it doesn't need to be reviewed again and we have a smaller ongoing feature branch. What do you think?
Sorry I misunderstood. Please ignore this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add localized strings, and run swiftlint/ swiftformat.
9713e5b
to
37db2c1
Compare
6449d7e
to
6732375
Compare
a76922a
to
7564aee
Compare
d8a8e75
to
0509462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I've commented about some differences in appearance compared to the designs I see in Figma
WireUI/Sources/WireReusableUIComponents/LabeledTextField/LabeledTextField.swift
Show resolved
Hide resolved
...ireAuthenticationUITests/Resources/ReferenceImages/SnapshotTestReferenceImageDirectory.swift
Show resolved
Hide resolved
7564aee
to
f8bbb94
Compare
3738e21
to
f2dba29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
f2dba29
to
78c9355
Compare
WireUI/Sources/WireAuthenticationUI/Views/AuthenticationIdentityInputView.swift
Show resolved
Hide resolved
WireUI/Sources/WireAuthenticationUI/Views/AuthenticationIdentityInputView.swift
Show resolved
Hide resolved
WireUI/Sources/WireAuthenticationUI/Views/AuthenticationIdentityInputView.swift
Show resolved
Hide resolved
1375a23
to
98f111a
Compare
Issue
Create the email input view
Testing
SwiftUI previews have been provided.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: