refactor: generate notification for new messages - WPB-11647 #2340
+2,080
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… category, title, body)
…ilders, clean up code
…e-notification-new-messages
echoes-hq
bot
added
echoes: technical-roadmap
Datadog ReportBranch report: ✅ 0 Failed, 1510 Passed, 2 Skipped, 3m 10.43s Total Time |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 8823f80. ♻️ This comment has been updated with latest results. |
netbe
reviewed
Jan 7, 2025
| @@ -98,10 +93,6 @@ extension Assembly { | |||
| self.pushChannel | |||
| } | |||
|
|
|||
| Injector.register(UpdateEventDecryptorProtocol.self) { | |||
There was a problem hiding this comment.
why is this remove from Assembly?
Comment on lines
+371
to
+373
| userInfo["selfUserIDString"] = context.selfUserID | ||
| userInfo["senderIDString"] = context.senderID | ||
| userInfo["conversationIDString"] = context.conversationID.uuid |
There was a problem hiding this comment.
is this going to be consumed to the main app? if so might be good to use constant for keys for safe access
Comment on lines
+64
to
+74
| Injector.register(ConversationLocalStoreProtocol.self) { | ||
| self.conversationLocalStore | ||
| } | ||
|
|
||
| Injector.register(UserLocalStoreProtocol.self) { | ||
| self.userLocalStore | ||
| } | ||
|
|
||
| Injector.register(MessageLocalStoreProtocol.self) { | ||
| self.messageLocalStore | ||
| } |
There was a problem hiding this comment.
don't we need to unregister the deps on teardown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPB-11647
Key points
This PR is about generating notification content related to new messages events specifically populating the right data in the notification (title, body, sound, category..) given the content of a message (a new message text, a reply, sharing a picture, an audio file, a video etc).
It introduces notification components such as NotificationCategory, NotificationTitle, NotificationBody, NotificationSound and dedicated builders to help generate the notification content.
Testing
Checklist
[WPB-XXX].