Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read receipts setting not synchronized after login - WPB-11738 #2338

Open
wants to merge 3 commits into
base: release/cycle-3.112
Choose a base branch
from
Open

fix: read receipts setting not synchronized after login - WPB-11738 #2338

wants to merge 3 commits into from
+30 −10

Conversation

johnxnguyen
Copy link
Collaborator

@johnxnguyen johnxnguyen commented Jan 2, 2025 •
edited by github-actions bot
Loading

BugWPB-11738 [iOS] Read receipt updates from web is not synchronized in iOS

…#2334)

Cherry pick of #2334

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@johnxnguyen
fix: read receipts setting not synchronized after login - WPB-11738 (#…
f5bfcda 
…2334)

# Conflicts:
#	wire-ios-request-strategy/Sources/Request Strategies/User/UserPropertyRequestStrategy.swift
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Test Results

3 552 tests   3 551 ✅  4m 9s ⏱️
  468 suites      0 💤
    3 files        1 ❌

For more details on these failures, see this check.

Results for commit 3cbc886.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 2, 2025 •
edited
Loading

Datadog Report

Branch report: fix/read-receipts-setting-cherry-pick
Commit report: cd3f7ef
Test service: wire-ios-mono

❌ 2 Failed (0 Known Flaky), 3556 Passed, 0 Skipped, 4.61s Total Time
❄️ 1 New Flaky

❌ Failed Tests (2)

  • testThatItDisplaysAudioMessage_55 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

  • testThatItDisplaysErrorForDeletedMessage_57 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

New Flaky Tests (1)

  • testThatItSendsTheHandshakeRequest - ZMWebSocketTests - Last Failure

    Expand for error 
     ((sentData) != nil) failed
 
 wire-ios-transport/Tests/Source/PushChannel/ZMWebSocketTests.m:222

@netbe netbe changed the title fix: read receipts setting not synchronized after login - WPB-11738 (#2334) fix: read receipts setting not synchronized after login - WPB-11738 Jan 6, 2025
@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/read-receipts-setting-cherry-pick
Commit report: 2a75c4c
Test service: wire-ios-mono

❌ 1 Failed (0 Known Flaky), 3551 Passed, 0 Skipped, 5.51s Total Time

❌ Failed Tests (1)

  • testThatItDisplaysAudioMessage_55 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnxnguyen johnxnguyen

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnxnguyen @netbe