chore: remove unused files - WPB-8605 #2221
Open
+428
−1,113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Test Results1 314 tests 1 312 ✅ 2m 8s ⏱️ Results for commit d43b568. ♻️ This comment has been updated with latest results. |
caldrian
changed the title
…ire-ios into feat/remove-dead-code-WPB-8605
netbe
commented
Dec 12, 2024
| @@ -259,6 +259,7 @@ public final class UserClientRequestStrategy: ZMObjectSyncStrategy, ZMObjectStra | |||
|
|
|||
| if keys.contains(ZMUserClientNeedsToUpdateSignalingKeysKey) { | |||
| do { | |||
| // what are these: signaling keys? what is it for? | |||
There was a problem hiding this comment.
@typfel I am trying to remove some files (ZMAPSMessageDecoder) you mention a while ago, is APSSignalingKeysStore still useful?
There was a problem hiding this comment.
APS signalling keys were used in the past to encrypt/decrypt the content of push notification back in the day when messages weren't end-2-end encrypted.
Datadog ReportBranch report: ✅ 0 Failed, 1294 Passed, 2 Skipped, 2m 8.64s Total Time |
netbe
force-pushed
the
feat/remove-dead-code-WPB-8605
branch
from
2cbd658 to
6309178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
These Objc files were not used. This PR removes them. See ticket for list of unused objc files.