-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enter to sent message UI part-2 [WPB-15369] #3845
Conversation
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/MessageComposerInput.kt
…-message-ui # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/composer/MessageComposerViewModel.kt # app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/EnabledMessageComposer.kt
103f95e
to
a7a08ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small question 🚀
app/src/main/kotlin/com/wire/android/ui/home/settings/appearance/CustomizationScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubaz added a valid question to move one label to strings.xml
, but I don't have any other so I'm just approving and Kubaz will give second approve when this string is resolved 😄
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3845 +/- ##
===========================================
+ Coverage 45.21% 45.23% +0.02%
===========================================
Files 491 491
Lines 16999 17006 +7
Branches 2845 2845
===========================================
+ Hits 7686 7693 +7
Misses 8529 8529
Partials 784 784
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3845.apk is available for download |
Built wire-android-dev-debug-pr-3845.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.