Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enter to sent message UI part-2 [WPB-15369] #3845

Merged
merged 15 commits into from
Feb 5, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 29, 2025


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. add UI for enable/disable enter to send

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 29, 2025
@MohamadJaara MohamadJaara requested review from saleniuk and Garzas and removed request for saleniuk January 29, 2025 08:47
…-message-ui

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/composer/MessageComposerViewModel.kt
#	app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/EnabledMessageComposer.kt
@MohamadJaara MohamadJaara force-pushed the feat/enter-to-sent-message-ui branch from 103f95e to a7a08ba Compare February 5, 2025 10:32
@MohamadJaara MohamadJaara requested a review from saleniuk February 5, 2025 10:33
Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question 🚀

Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubaz added a valid question to move one label to strings.xml, but I don't have any other so I'm just approving and Kubaz will give second approve when this string is resolved 😄

Copy link

sonarqubecloud bot commented Feb 5, 2025

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.23%. Comparing base (fc53baf) to head (d5711fd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../com/wire/android/ui/home/settings/SettingsItem.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3845      +/-   ##
===========================================
+ Coverage    45.21%   45.23%   +0.02%     
===========================================
  Files          491      491              
  Lines        16999    17006       +7     
  Branches      2845     2845              
===========================================
+ Hits          7686     7693       +7     
  Misses        8529     8529              
  Partials       784      784              
Files with missing lines Coverage Δ
...conversations/composer/MessageComposerViewModel.kt 71.42% <100.00%> (ø)
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
.../ui/home/settings/appearance/CustomizationState.kt 100.00% <100.00%> (ø)
...home/settings/appearance/CustomizationViewModel.kt 100.00% <100.00%> (ø)
.../com/wire/android/ui/home/settings/SettingsItem.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc53baf...d5711fd. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Built wire-android-staging-compat-pr-3845.apk is available for download

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Built wire-android-dev-debug-pr-3845.apk is available for download

Merged via the queue into develop with commit 5084c57 Feb 5, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the feat/enter-to-sent-message-ui branch February 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants