feat: Add is team member segmentation to app.open event (WPB-14523) #3841
Conversation
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
…-segmentation-to-app.open-event # Conflicts: # core/analytics/src/main/kotlin/com/wire/android/feature/analytics/model/AnalyticsEvent.kt
| val isTeamMember = if (currentSessionResult is CurrentSessionResult.Success) { | ||
| coreLogic.get().getSessionScope(currentSessionResult.accountInfo.userId).team.isSelfATeamMember() | ||
| } else { | ||
| null |
There was a problem hiding this comment.
are you sure about null, maybe false? If user is not logged in - user is not in a team :)
There was a problem hiding this comment.
If we pass false, it means we have a personal user logged in. So better to keep undefined and pass null to not send isTeamMember segmentation at all if there is no user logged in.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3841 +/- ##
===========================================
- Coverage 45.41% 45.40% -0.02%
===========================================
Files 490 490
Lines 16904 16909 +5
Branches 2839 2840 +1
===========================================
Hits 7677 7677
- Misses 8441 8446 +5
Partials 786 786
Continue to review full report in Codecov by Sentry.
|
|
Built wire-android-staging-compat-pr-3841.apk is available for download |
|
Built wire-android-dev-debug-pr-3841.apk is available for download |
ohassine
requested review from
a team,
alexandreferris,
MohamadJaara,
vitorhugods,
saleniuk,
mathias-niboulies and
yamilmedina
and removed request for
a team and
mathias-niboulies
|
|
Built wire-android-staging-compat-pr-3841.apk is available for download |
|
Built wire-android-dev-debug-pr-3841.apk is available for download |
ohassine
deleted the
add-is-team-member-segmentation-to-app.open-event
branch
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
is_team_membersegmentation is now required in app.open event.Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.