Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Temporarily stopping sending ui.clicked-profile event (WPB-15246) #3836

Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 27, 2025

TaskWPB-15246 Disabling Countly profile page tracking


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

By a request from product, we need to temporarily disable ui.clicked-profile event (details in Jira ticket)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 27, 2025
@ohassine ohassine requested review from a team, typfel, sbakhtiarov, yamilmedina, saleniuk and mathias-niboulies and removed request for a team January 27, 2025 13:45
Copy link
Contributor

Built wire-android-staging-compat-pr-3836.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3836.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3836.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3836.apk is available for download

@ohassine ohassine requested review from borichellow and removed request for mathias-niboulies January 28, 2025 10:01
@ohassine ohassine added this pull request to the merge queue Jan 28, 2025
Merged via the queue into develop with commit 65de869 Jan 28, 2025
12 checks passed
@ohassine ohassine deleted the Temporarily-stopping-sending-ui.clicked-profile-event branch January 28, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants