Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Audio wave mask fixes #WPB-11723 #3834

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Jan 27, 2025

StoryWPB-11723 [Android] Playback improvement - 1 - Scroll / Duration / Speed

What's new in this PR?

Issues

After adding a new design for AudioMessages, 2 issues found out:

  1. crash when recorded message has no any sound
  2. when recorded message is ready to send and user could listen it: waves covered by "close" button

Causes (Optional)

  1. there is a dividing by 0, when calculating waves and equalising them.
  2. just a compose issue, didn't seen before

Solutions

  1. if all the waves are 0 - do nothing for equalising them
  2. just add spacing to move recorded message a bit down.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
photo_5240078122706136187_y photo_5240078122706136188_y

@borichellow borichellow self-assigned this Jan 27, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 27, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.43%. Comparing base (25f96c5) to head (029e783).

Files with missing lines Patch % Lines
...android/media/audiomessage/AudioWavesMaskHelper.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3834      +/-   ##
===========================================
- Coverage    45.44%   45.43%   -0.01%     
===========================================
  Files          490      490              
  Lines        16900    16902       +2     
  Branches      2833     2834       +1     
===========================================
  Hits          7680     7680              
- Misses        8434     8436       +2     
  Partials       786      786              
Files with missing lines Coverage Δ
...android/media/audiomessage/AudioWavesMaskHelper.kt 3.57% <0.00%> (-0.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f96c5...029e783. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3834.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3834.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit c93beee Jan 30, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the fix/audio_wave_mask_fixes branch January 30, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants