Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is_team_member and user_type segmentations (WPB-14646) #3832

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 27, 2025

BugWPB-14646 [Android] Segmentation missing for countly events


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

  • Product team added is_team_member and user_type segmentations to ui.QR-click, user.back.share-profile and user.share-profile events.
  • ui.share.profile event is removed for redundancy reasons

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 27, 2025
@ohassine ohassine requested review from a team, typfel, sbakhtiarov, yamilmedina, vitorhugods and emmaoke-w and removed request for a team January 27, 2025 12:22
@ohassine ohassine enabled auto-merge January 27, 2025 16:45
@ohassine ohassine added this pull request to the merge queue Jan 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (25f96c5) to head (65a0d10).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3832   +/-   ##
========================================
  Coverage    45.44%   45.45%           
========================================
  Files          490      490           
  Lines        16900    16904    +4     
  Branches      2833     2833           
========================================
+ Hits          7680     7683    +3     
- Misses        8434     8435    +1     
  Partials       786      786           
Files with missing lines Coverage Δ
.../wire/android/ui/userprofile/qr/SelfQRCodeState.kt 100.00% <100.00%> (ø)
...e/android/ui/userprofile/qr/SelfQRCodeViewModel.kt 54.54% <100.00%> (+0.88%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f96c5...65a0d10. Read the comment docs.

Merged via the queue into develop with commit 3b4eaad Jan 27, 2025
12 of 13 checks passed
@ohassine ohassine deleted the add-user_type-isteam-member-segmentations branch January 27, 2025 17:47
Copy link
Contributor

Built wire-android-staging-compat-pr-3832.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3832.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants