Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enterprise login, adjust style initial screen - remove footer (WPB-15520) #3830

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 24, 2025

TaskWPB-15520 [Android] - Implement error handling for initial screens


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Adjust designs, footer was removed from the first screen.
  • Fix detekt issues

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from saleniuk January 24, 2025 14:56
@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 24, 2025
@yamilmedina yamilmedina changed the title feat: adjust style initial screen - remove footer (WPB-15520) feat: enterprise login, adjust style initial screen - remove footer (WPB-15520) Jan 24, 2025
@yamilmedina yamilmedina merged commit ebaeb20 into epic/new-sso-login-flow Jan 27, 2025
10 of 11 checks passed
@yamilmedina yamilmedina deleted the feat/adjust-style-initial-screen branch January 27, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: scale Enterprise Readiness Initiatives size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants