Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection lost on update of share conversation list [#WPB-14911] #3804

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Jan 15, 2025

BugWPB-14911 [Android]Conversation selection unhighlighted after list reordering

https://wearezeta.atlassian.net/browse/WPB-14911

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

After receiving an update list of conversations for sharing is re-arranged and selection is lost.

Causes (Optional)

ViewModel keeps conversation object as key for selection. After updating conversation list the equals check does not return true since objects are updated.

Solutions

Use conversation id as a key for selected conversation.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 15, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.63%. Comparing base (cdfd79a) to head (a00bc0a).

Files with missing lines Patch % Lines
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3804   +/-   ##
========================================
  Coverage    45.63%   45.63%           
========================================
  Files          485      485           
  Lines        16569    16569           
  Branches      2783     2783           
========================================
  Hits          7562     7562           
  Misses        8227     8227           
  Partials       780      780           
Files with missing lines Coverage Δ
...ndroid/ui/sharing/ImportMediaAuthenticatedState.kt 87.50% <100.00%> (ø)
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 32.69% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfd79a...a00bc0a. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3804.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3804.apk is available for download

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Jan 16, 2025
Merged via the queue into develop with commit f1eef77 Jan 16, 2025
12 of 13 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/share-conversation-list-update branch January 16, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants