Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove conversation from folder [WPB-14630] #3803

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 15, 2025

BugWPB-14630 [Android] Conversation folder - Remove from folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • remove conversation from folder in Conversation List Screen and Conversation Details Screen

Attachments (Optional)

screen-20250115-115200.mp4

@Garzas Garzas self-assigned this Jan 15, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 45.63%. Comparing base (b0aa25c) to head (5c154e3).

Files with missing lines Patch % Lines
...ersations/folder/RemoveConversationFromFolderVM.kt 0.00% 26 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3803      +/-   ##
===========================================
- Coverage    45.70%   45.63%   -0.07%     
===========================================
  Files          484      485       +1     
  Lines        16546    16569      +23     
  Branches      2781     2783       +2     
===========================================
  Hits          7562     7562              
- Misses        8204     8227      +23     
  Partials       780      780              
Files with missing lines Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 67.74% <ø> (+0.36%) ⬆️
...roupConversationDetailsBottomSheetEventsHandler.kt 0.00% <ø> (ø)
...ersations/folder/RemoveConversationFromFolderVM.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0aa25c...5c154e3. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3803.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3803.apk is available for download

Copy link
Contributor

@Garzas looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
b016dd9f6d3d053be275fe57e3b50ecb68b32d14 b304f302a20874093809dea89e03016515d7c9fe

Is this intentional?

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3803.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3803.apk is available for download

@Garzas Garzas added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit cdfd79a Jan 15, 2025
13 of 14 checks passed
@Garzas Garzas deleted the feat/remove-conversation-from-folder branch January 15, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants