feat: AudioMessages play in background part 2 #WPB-11725 #3802
+820
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
…_messages_play_in_background_part_2
|
borichellow
requested review from
saleniuk,
MohamadJaara,
sbakhtiarov and
Garzas
borichellow
changed the title
echoes-hq
bot
added
the
echoes: product-roadmap
saleniuk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Audio messages should be played even when user leave the conversation screen, or hide the application.
Also message should be paused when other audio source comes on device.
Solutions
Start Foreground service on start playing Audio message (
PlayingAudioMessageService)Also added
StopAudioMessageReceiverandPlayPauseAudioMessageReceiverfor handling audio control in notification.Updated
ConversationAudioMessagePlayernow it's a singleton and can be used from service.Testing
Test Coverage (Optional)
Attachments (Optional)
document_5206496726445220531.mp4