-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactoring self user fetch [#WPB-15190] #3801
Conversation
1b3b34d
to
ce12e33
Compare
@sbakhtiarov looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small suggestion but I'm approving as the rest looks ok
c9119be
to
f516e21
Compare
b01b7d7
to
35126ba
Compare
35126ba
to
f4ccd86
Compare
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3801.apk is available for download |
Built wire-android-dev-debug-pr-3801.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-15190
What's new in this PR?
Related to: wireapp/kalium#3229
Refactoring getting / observe self user. New
GetSelfUserUseCase
use case to get self user is used where appropriate instead of observing until first value is received.