Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emoji picker dialog showing randomly [#WPB-6681] #3796

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Jan 13, 2025

BugWPB-6681 [Android] Emoji list appears on screen unnecessaryly

https://wearezeta.atlassian.net/browse/WPB-6681

What's new in this PR?

Issues

Emoji picker dialog is showing again in random places:

  1. Open message reaction dialog. Open all emojis picker.
  2. Select emoji.
  3. Go to settings -> Give Feedback.
  4. Close feedback dialog.
  5. Emoji picker is shown on top of the screen and can only be dismissed by re-opening the app.

Causes (Optional)

Emoji picker dialog is not dismissed when picking emoji and it's state is restored.

Solutions

Dismiss dialog when emoji is selected.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 13, 2025
Copy link
Contributor

Built wire-android-staging-compat-pr-3796.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3796.apk is available for download

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Jan 13, 2025
Merged via the queue into develop with commit 2f1c38d Jan 13, 2025
13 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/emoji-picker-dialog branch January 13, 2025 14:44
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants