Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show Guest label for personal users after migration in conversations screen - cherrypick (WPB-14871) 🍒 #3783

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2025

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-14871 [Android] Guest label for personal users only shown after migration once conversation is opened

…tions screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some UX improvements done here:

  • show loading state after pressing migrate button
  • Disable Continue and Back buttons while the migration is ongoing

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and sergeibakhtiarov and removed request for a team January 3, 2025 16:35
@ohassine ohassine enabled auto-merge January 3, 2025 16:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.80%. Comparing base (73cf82e) to head (f5bd451).

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3783   +/-   ##
========================================
  Coverage    45.79%   45.80%           
========================================
  Files          483      483           
  Lines        16511    16513    +2     
  Branches      2783     2783           
========================================
+ Hits          7562     7563    +1     
- Misses        8169     8170    +1     
  Partials       780      780           
Files with missing lines Coverage Δ
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...serprofile/teammigration/TeamMigrationViewModel.kt 88.46% <0.00%> (-1.74%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cf82e...f5bd451. Read the comment docs.

@ohassine ohassine changed the title feat: show Guest label for personal users after migration in conversations screen - RC (WPB-14871) 🍒 feat: show Guest label for personal users after migration in conversations screen - cherrypick (WPB-14871) 🍒 Jan 3, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

@ohassine ohassine added this pull request to the merge queue Jan 6, 2025
Merged via the queue into develop with commit 4883d0e Jan 6, 2025
11 of 13 checks passed
@ohassine ohassine deleted the Guest-label-for-personal-users-not-shown-after-migration-cherry-pick branch January 6, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants