-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Keyboard overlapping attachments [#WPB-11039] #3780
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3780 +/- ##
========================================
Coverage 45.91% 45.91%
========================================
Files 482 482
Lines 16438 16438
Branches 2769 2769
========================================
Hits 7547 7547
Misses 8115 8115
Partials 776 776
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3780.apk is available for download |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3780.apk is available for download |
Built wire-android-dev-debug-pr-3780.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-11039
What's new in this PR?
Issues
Our attachment type view was overlapping the attachments components itself on some devices.
Solutions
The logic assumed that we take the keyboard height, but if its lower than 250.dp we fallback to that 250.dp value, which could be useful in situations where we could not get the keyboard size. But this also was a problem for devices on which the keyboard itself had height less than those 250.dp resulting in the overlap.
Since the overlap was never that big, I've changed the value for 200.dp which is fine to displayu all the options but also (on my testing devices) does not overlap the component.
We could also eventually use the value only when keyboard size is 0, but if we would get the size of keyboard in the range of 10-160.dp the view itself would be disorted.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.