Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keyboard overlapping attachments [#WPB-11039] #3780

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 31, 2024

BugWPB-11039 [Android] Keyboard partially hiding attachment section

https://wearezeta.atlassian.net/browse/WPB-11039

What's new in this PR?

Issues

Our attachment type view was overlapping the attachments components itself on some devices.

Solutions

The logic assumed that we take the keyboard height, but if its lower than 250.dp we fallback to that 250.dp value, which could be useful in situations where we could not get the keyboard size. But this also was a problem for devices on which the keyboard itself had height less than those 250.dp resulting in the overlap.
Since the overlap was never that big, I've changed the value for 200.dp which is fine to displayu all the options but also (on my testing devices) does not overlap the component.
We could also eventually use the value only when keyboard size is 0, but if we would get the size of keyboard in the range of 10-160.dp the view itself would be disorted.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.91%. Comparing base (118f45b) to head (5eab901).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...mposer/state/MessageCompositionInputStateHolder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3780   +/-   ##
========================================
  Coverage    45.91%   45.91%           
========================================
  Files          482      482           
  Lines        16438    16438           
  Branches      2769     2769           
========================================
  Hits          7547     7547           
  Misses        8115     8115           
  Partials       776      776           
Files with missing lines Coverage Δ
...mposer/state/MessageCompositionInputStateHolder.kt 63.41% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118f45b...5eab901. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3780.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Dec 31, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3780.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3780.apk is available for download

Merged via the queue into develop with commit 4896d60 Dec 31, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the fix/keyboard-overlapping-attachments branch December 31, 2024 10:46
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants