fix: show no connection banner faster [#WPB-11568] #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
|
Built wire-android-staging-compat-pr-3776.apk is available for download |
|
Built wire-android-dev-debug-pr-3776.apk is available for download |
ohassine
approved these changes
Dec 30, 2024
|
Built wire-android-staging-compat-pr-3776.apk is available for download |
|
Built wire-android-dev-debug-pr-3776.apk is available for download |
yamilmedina
approved these changes
Dec 31, 2024
|
echoes-hq
bot
added
echoes: product-roadmap/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-11568
What's new in this PR?
Showing the No Connection banner instantly when Internet connection is lost.
Issues
After turning on Airplane mode the 'Waiting for connection' banner may be shown with a long delay.
Causes
Displaying the banner is based on observed sync status which is set to Failed when WebSocket throws exception on connection loss. The problem is that the WebSocket is not guaranteed to detect the connection loss immediately and sometimes it throws exception only after the failed ping attempt (in 20 sec).
Solutions
Observe network state in addition to sync state to detect faster the 'no connection' situation and show the banner instantly.