Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Audio message play in background WPB-11725 #3766

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 23, 2024

StoryWPB-11725 [Android] Playback improvement - 2 - Auto playback/Background play

this is the first PR from 2, next is coming soon and will be merged into this branch.

What's new in this PR?

  1. Audio message could be played even when user leave conversation screen
  2. When audio message ended the next audio message in conversation (if exist) starts automatically, without any actions from user side
  3. Audio control buttons in ConversationItem in ConversationsList screen.

Attachments (Optional)

Screenshot 2024-12-23 at 12 25 04

@borichellow borichellow self-assigned this Dec 23, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 23, 2024
Base automatically changed from feat/audio_messages_new_design to develop December 27, 2024 14:06
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 57.07071% with 85 lines in your changes missing coverage. Please review.

Project coverage is 45.78%. Comparing base (8d45505) to head (4148493).

Files with missing lines Patch % Lines
...dia/audiomessage/ConversationAudioMessagePlayer.kt 55.38% 53 Missing and 5 partials ⚠️
...ome/conversationslist/ConversationListViewModel.kt 40.00% 9 Missing ⚠️
...tlin/com/wire/android/mapper/ConversationMapper.kt 41.66% 6 Missing and 1 partial ⚠️
...i/home/conversationslist/model/ConversationItem.kt 33.33% 4 Missing ⚠️
...rsations/messages/ConversationMessagesViewModel.kt 70.00% 3 Missing ⚠️
.../com/wire/android/media/audiomessage/AudioState.kt 89.47% 2 Missing ⚠️
...tions/usecase/GetConversationsFromSearchUseCase.kt 75.00% 0 Missing and 1 partial ⚠️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3766      +/-   ##
===========================================
+ Coverage    45.77%   45.78%   +0.01%     
===========================================
  Files          485      485              
  Lines        16556    16643      +87     
  Branches      2781     2791      +10     
===========================================
+ Hits          7578     7620      +42     
- Misses        8198     8240      +42     
- Partials       780      783       +3     
Files with missing lines Coverage Δ
...rsations/messages/ConversationMessagesViewState.kt 100.00% <100.00%> (ø)
...tions/usecase/GetConversationsFromSearchUseCase.kt 81.48% <75.00%> (+0.71%) ⬆️
...essagecomposer/recordaudio/RecordAudioViewModel.kt 64.58% <0.00%> (ø)
.../com/wire/android/media/audiomessage/AudioState.kt 69.01% <89.47%> (+10.08%) ⬆️
...rsations/messages/ConversationMessagesViewModel.kt 68.89% <70.00%> (-1.28%) ⬇️
...i/home/conversationslist/model/ConversationItem.kt 54.54% <33.33%> (-1.56%) ⬇️
...tlin/com/wire/android/mapper/ConversationMapper.kt 64.54% <41.66%> (-3.46%) ⬇️
...ome/conversationslist/ConversationListViewModel.kt 33.68% <40.00%> (+0.35%) ⬆️
...dia/audiomessage/ConversationAudioMessagePlayer.kt 59.25% <55.38%> (-5.35%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d45505...4148493. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Built wire-android-dev-debug-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3766.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3766.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants