-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: non-paginated conversation list is not loading [WPB-15066] #3747
fix: non-paginated conversation list is not loading [WPB-15066] #3747
Conversation
…on-paginated-conversations-not-loading
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3747 +/- ##
===========================================
- Coverage 45.73% 45.70% -0.03%
===========================================
Files 477 477
Lines 16186 16183 -3
Branches 2740 2741 +1
===========================================
- Hits 7403 7397 -6
- Misses 8016 8018 +2
- Partials 767 768 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
On current 4.11 staging build, the conversation list is not loading at all after fresh install and fresh login.
Causes (Optional)
For non-paginated state,
conversationListState
is created by usingnotPaginatedConversationListState
but looks like it's using it as a value instead of using it as a state that can change and should then recompose.Solutions
Two separate states are not needed and can unnecessarily use resources, so merge them into a single one - for paginated just pass single value initially with the paginated flow, for non-patinated just update
conversationListState
directly.Also, added
backStackMode
to the navigation command log so that it's more clear what the command is supposed to do.Testing
How to Test
Use a build version that doesn't have
paginated_conversation_list_enabled
enabled (currently onlyinternal
andprod
have it enabled), fresh install, log in and open the app - it should load conversation list properly and not be stuck in loading state.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.