Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies (WPB-6394) #3698

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 3, 2024

TopicWPB-6394 [Android] General Improvements


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Updating dependencies to latest version

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Dec 3, 2024

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, borichellow, saleniuk and sergeibakhtiarov and removed request for a team December 3, 2024 09:08
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Built wire-android-staging-compat-pr-3698.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Built wire-android-dev-debug-pr-3698.apk is available for download

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to update Kotlin to 2.0 as well 😋

Soon™

@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 674bc9e Dec 4, 2024
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the update-dependencies branch December 4, 2024 08:40
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants