-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lateinit property selfUserId has not been initialized in ConversationInfoViewModel [WPB-14317] #3632
fix: lateinit property selfUserId has not been initialized in ConversationInfoViewModel [WPB-14317] #3632
Conversation
…ationInfoViewModel
…d-has-not-been-initialized
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3632 +/- ##
=====================================================
- Coverage 45.35% 45.34% -0.02%
=====================================================
Files 471 471
Lines 15845 15842 -3
Branches 2655 2655
=====================================================
- Hits 7187 7184 -3
Misses 7885 7885
Partials 773 773
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3632.apk is available for download |
…ationInfoViewModel [WPB-14317] (#3632)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
lateinit property selfUserId has not been initialized in ConversationInfoViewModel
Causes (Optional)
the lateinit property is updated in async and we can not guaranties that it will be fetched on time for when it is used
Solutions
there is no need to fetch self user from the db and we can use in memory cache of the current user id
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.