Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable conversation list pagination for internal app [WPB-14295] #3626

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 13, 2024

TaskWPB-14295 [Android] enable conversation pagination for internal


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

since @saleniuk fixed pagination it will be nice to enable it in one of the internal apps and use it as edge testing

Solutions

  1. fix the internal build script to publish to the correct track
  2. enable conversation list pagination there

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title chore: enable conversation list pagination for internal app chore: enable conversation list pagination for internal app [WPB-14295] Nov 13, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 13, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3626.apk is available for download

Merged via the queue into release/candidate with commit cca1fa5 Nov 13, 2024
14 of 16 checks passed
@MohamadJaara MohamadJaara deleted the chore/enable-internal-edge-track branch November 13, 2024 18:00
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants