-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve logging for backups (WPB-12113) #3595
Conversation
@yamilmedina looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
@yamilmedina looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3595 +/- ##
=====================================================
- Coverage 45.29% 45.27% -0.02%
=====================================================
Files 470 470
Lines 15797 15802 +5
Branches 2655 2655
=====================================================
Hits 7155 7155
- Misses 7874 7879 +5
Partials 768 768
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3595.apk is available for download |
@yamilmedina looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3595.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Logging was not being performed for importing backups
Causes (Optional)
Difficulty to troubleshoot problems related to it
Solutions
Implement logging, to add more info about failures.
Testing
Test Coverage (Optional)
Depends on
How to Test
Fail to import a backup, you should see more info related to the failure.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.