Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve logging for backups (WPB-12113) #3595

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 6, 2024

TaskWPB-12113 [Android] Improve logging for backups


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Logging was not being performed for importing backups

Causes (Optional)

Difficulty to troubleshoot problems related to it

Solutions

Implement logging, to add more info about failures.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Depends on

How to Test

Fail to import a backup, you should see more info related to the failure.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
358a6236bbcd6d650f97ddd5fb31ffd91877a617 1f4dd107a228140cf084405f33258ef6aac8f84c

Is this intentional?

@yamilmedina yamilmedina requested review from a team, typfel, borichellow, vitorhugods, Garzas and ohassine and removed request for a team November 6, 2024 14:07
Copy link
Contributor

github-actions bot commented Nov 6, 2024

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
358a6236bbcd6d650f97ddd5fb31ffd91877a617 46080c7a5f5242964cf5fe97478e4d0c50fc476f

Is this intentional?

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.27%. Comparing base (ccb1b8b) to head (2d2e514).
Report is 4 commits behind head on release/candidate.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3595      +/-   ##
=====================================================
- Coverage              45.29%   45.27%   -0.02%     
=====================================================
  Files                    470      470              
  Lines                  15797    15802       +5     
  Branches                2655     2655              
=====================================================
  Hits                    7155     7155              
- Misses                  7874     7879       +5     
  Partials                 768      768              
Files with missing lines Coverage Δ
.../home/settings/backup/BackupAndRestoreViewModel.kt 87.11% <100.00%> (-0.08%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb1b8b...2d2e514. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-staging-compat-pr-3595.apk is available for download

Copy link
Contributor

github-actions bot commented Nov 7, 2024

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
358a6236bbcd6d650f97ddd5fb31ffd91877a617 83207c730fd36ac4aa2c6fdc11338dd18fc51333

Is this intentional?

Copy link

sonarqubecloud bot commented Nov 7, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Built wire-android-staging-compat-pr-3595.apk is available for download

Merged via the queue into release/candidate with commit 55863ae Nov 7, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the chore/improv-backup-logging branch November 7, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants