feat: Try testTagsAsResourceId to improve UI tests: RC [WPB-9284] #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
vitorhugods,
Garzas,
saleniuk and
damian-kaczmarek
|
Built wire-android-staging-compat-pr-3594.apk is available for download |
damian-kaczmarek
suggested changes
Nov 6, 2024
| @@ -203,6 +207,7 @@ class WireActivity : AppCompatActivity() { | |||
| } | |||
| } | |||
|
|
|||
| @Suppress("LongMethod") | |||
There was a problem hiding this comment.
Please extract CommonTopAppBar call to separate function instead.
|
damian-kaczmarek
approved these changes
Nov 6, 2024
|
Built wire-android-staging-compat-pr-3594.apk is available for download |
yamilmedina
approved these changes
Nov 6, 2024
borichellow
deleted the
feat/try_test_tags_as_resource_id_to_improve_ui_tests_rc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RC cherry-pick of #3588
What's new in this PR?
Add
testTagsAsResourceIdto WireActivity. So the ui elements become accessible to UI tests bytestTag.