Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when starting starting PersistentWebsocketService (WPB-10712) - cherrypick RC #3353

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 21, 2024

BugWPB-10712 Crash when starting PersistentWebsocketService


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #3351

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, MohamadJaara, mchenani and saleniuk and removed request for a team August 21, 2024 15:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.73%. Comparing base (8bd27f1) to head (cc1e09d).
Report is 31 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...ire/android/services/PersistentWebSocketService.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3353      +/-   ##
=====================================================
- Coverage              44.74%   44.73%   -0.01%     
=====================================================
  Files                    456      456              
  Lines                  15396    15398       +2     
  Branches                2573     2574       +1     
=====================================================
  Hits                    6889     6889              
- Misses                  7780     7782       +2     
  Partials                 727      727              
Files with missing lines Coverage Δ
...ire/android/services/PersistentWebSocketService.kt 3.77% <0.00%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd27f1...cc1e09d. Read the comment docs.

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3353.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 22, 2024
Merged via the queue into release/candidate with commit b95dbbb Aug 22, 2024
13 checks passed
@MohamadJaara MohamadJaara deleted the crash-persistent-websocket-rc branch August 22, 2024 07:50
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants