Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove direct usage of Lazy<CoreLogic> (WPB-10304) 🍒 #3313

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 12, 2024

BugWPB-10304 [Android] circular dependency on app start

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Crash is still happening

Solutions

Raise now approach n#2 of removing Lazy<> from Lazy<CoreLogic>

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS labels Aug 12, 2024
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.51%. Comparing base (cbf98aa) to head (f4a3abd).

Files Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 75.00% 2 Missing ⚠️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 86.66% 2 Missing ⚠️
...ialog/deactivated/LegalHoldDeactivatedViewModel.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3313   +/-   ##
========================================
  Coverage    44.51%   44.51%           
========================================
  Files          453      453           
  Lines        15335    15335           
  Branches      2560     2560           
========================================
  Hits          6827     6827           
  Misses        7791     7791           
  Partials       717      717           
Files Coverage Δ
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 88.63% <100.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 74.49% <75.00%> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 56.57% <86.66%> (ø)
...ialog/deactivated/LegalHoldDeactivatedViewModel.kt 81.57% <60.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf98aa...f4a3abd. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3313.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3313.apk is available for download

@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, alexandreferris, MohamadJaara and ohassine and removed request for a team August 13, 2024 06:46
@alexandreferris alexandreferris added this pull request to the merge queue Aug 13, 2024
Merged via the queue into develop with commit 23a615d Aug 13, 2024
12 checks passed
@alexandreferris alexandreferris deleted the fix/remove_direct_usage_of_lazy_in_corelogic-cherry-pick branch August 13, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants