fix: Remove Reset Session for MLS conversations #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
alexandreferris,
MohamadJaara,
mchenani,
Garzas and
saleniuk
borichellow
commented
Aug 8, 2024
| @@ -240,6 +242,9 @@ internal fun MessageDecryptionFailure( | |||
| text = stringResource(R.string.label_learn_more) | |||
| ) | |||
| VerticalSpace.x4() | |||
|
|
|||
| if (conversationProtocol !is Conversation.ProtocolInfo.Proteus) return@Column | |||
There was a problem hiding this comment.
in fact this is the only changes in Compose, all others - just refactoring to make it more readable
Test Results860 tests 860 ✅ 12m 37s ⏱️ Results for commit 2e7d1a6. ♻️ This comment has been updated with latest results. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationTopAppBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageItemComponents.kt
Outdated
Show resolved
Hide resolved
|
alexandreferris
approved these changes
Aug 9, 2024
|
APKs built during tests are available here. Scroll down to Artifacts! |
yamilmedina
approved these changes
Aug 9, 2024
This was referenced Aug 9, 2024
echoes-hq
bot
added
echoes: technical-roadmap/technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When we receive decryption errors in an MLS conversation, we show a “reset session” button.
But this button does not help to reset the session and is useless.
Therefore, we should hide it and not show it to the user.
Causes (Optional)
Nobody think about differences in MLS conversations :)
Solutions
Think about it and remove "Reset Session" btn and text "Try resetting the session ..." text