-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app registering many config sync jobs [WPB-10234] #3275
fix: app registering many config sync jobs [WPB-10234] #3275
Conversation
…any-config-sync-jobs # Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/UserModule.kt # kalium
…into fix/app-registring-many-config-sync-jobs # Conflicts: # kalium
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3275 +/- ##
=====================================================
+ Coverage 44.67% 44.75% +0.07%
=====================================================
Files 456 456
Lines 15361 15374 +13
Branches 2560 2565 +5
=====================================================
+ Hits 6862 6880 +18
+ Misses 7780 7772 -8
- Partials 719 722 +3
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3275.apk is available for download |
Built wire-android-internal-compat-pr-3275.apk is available for download |
Built wire-android-staging-compat-pr-3275.apk is available for download |
Built wire-android-internal-compat-pr-3275.apk is available for download |
…registring-many-config-sync-jobs # Conflicts: # kalium
@MohamadJaara looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3275.apk is available for download |
Built wire-android-internal-compat-pr-3275.apk is available for download |
Co-authored-by: Mojtaba Chenani <[email protected]> (cherry picked from commit 9b875dd)
Co-authored-by: Yamil Medina <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
all of this is cauing multiple config sync jobs to run
Solutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.