Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty backup file name [WPB-10210] #3253

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: empty backup file name [WPB-10210] #3253

merged 2 commits into from
Jul 30, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jul 30, 2024 •
edited by github-actions bot
Loading

BugWPB-10210 [Android] When saving a backup, we do not show the backup name anymore

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When create dialog is showed there is empty file name, because it's created after creating backup. Because of that rememberCheckPermissionsRequestFlow is only composed at start with empty value and it's not recomposing after file name is updated.

Causes (Optional)

Empty file name when user wants to save a backup

Solutions

Add key to rememberCheckPermissionsRequestFlow to recompose it when file name will change

@Garzas Garzas requested review from alexandreferris, saleniuk and a team July 30, 2024 14:15
@Garzas Garzas self-assigned this Jul 30, 2024
@Garzas Garzas requested review from typfel, vitorhugods and ohassine and removed request for a team July 30, 2024 14:15
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

alexandreferris
alexandreferris approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Garzas Garzas enabled auto-merge July 30, 2024 14:41
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3253.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3253.apk is available for download

@Garzas Garzas added this pull request to the merge queue Jul 30, 2024
Merged via the queue into release/candidate with commit ffa5f1c Jul 30, 2024
17 of 18 checks passed
@Garzas Garzas deleted the fix/empty-backup-file-name branch July 30, 2024 16:10
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@Garzas @github-actions
fix: empty backup file name [WPB-10210] (#3253)
33dd446
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@saleniuk saleniuk saleniuk approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garzas @alexandreferris @saleniuk