Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block sending empty messages, also empty markdowns [WPB-10179] #3231

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jul 25, 2024

BugWPB-10179 [Android] We can send empty messages, spaces or breaking lines


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We can send empty messages, spaces or breaking lines in the conversations.

Causes (Optional)

isNotEmpty() used instead of isNotBlank(), but that still does not block the user from sending messages with empty markdowns, like # .

Solutions

Check if the message that the user writes is not blank and is not "markdown blank" which means it doesn't contain any markdown with actual text. It uses our markdown helper so it should behave exactly the same as showing the message, messages that would appear empty will be blocked from being sent.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Enter message with only whitespaces or with markdowns containing only whitespaces and try to send that message - .


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 25, 2024
@saleniuk saleniuk requested a review from Garzas July 25, 2024 07:05
@saleniuk saleniuk requested review from a team, alexandreferris, borichellow, vitorhugods and mchenani and removed request for a team July 25, 2024 07:05
Copy link

Copy link
Contributor

Built wire-android-staging-release-pr-3231.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3231.apk is available for download

@saleniuk saleniuk added this pull request to the merge queue Jul 25, 2024
Merged via the queue into release/candidate with commit 1d1e9fd Jul 25, 2024
13 of 14 checks passed
@saleniuk saleniuk deleted the fix/sending-empty-messages branch July 25, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants