fix: flickering call other participants video (WPB-9617) #3188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
TL;DR; This PR #3034 upgraded the compose libraries to beta01. That had an unintended side effect with
AndroidView
component that we use for rendering other participants video streams.A long story of debugging and side effects.
After checking recompositions and validating that these were skipped, as well, validating the code visually. I checked for the latest working version, this being initially (4.6.4) previous prod.
The candidates that could have introduced the bug were:
And no clue after those were ok, so checking with @ohassine the idea came to validate for dependencies changes. We stumbled upon the PR with the regression, this by validating installing and updating old Apks.
The issue was no present in
1.7.0-alpha05
but it is from1.7.0-beta01
to1.7.0-beta04
.The fix is present in the latest version
1.7.0-beta05
https://developer.android.com/jetpack/androidx/releases/compose-ui#1.7.0-beta05Causes (Optional)
Regression in the compose dependency.
Solutions
Bump to the newest version, and also avoid unnecessary collection of the flow emissions for call state (not related, but efficient improvement)
Testing
Tested manually after version bump.
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.