Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset restriction [WPB-9947] (#3114) (#3147) #3150

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 2, 2024

TaskWPB-9947 [Android] Implement asset sending restriction

Co-authored-by: yamilmedina [email protected]

(cherry picked from commit 85d5a1e)

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

asset restriction when sending, was not implemented

Solutions

show a snack bar error messag when sending a restricted file

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Test Results

857 tests   857 ✅  14m 45s ⏱️
117 suites    0 💤
117 files      0 ❌

Results for commit 7c13e86.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara changed the title fix: asset restriction [WPB-9947] (#3114) (#3147) fix: asset restriction [WPB-9947] (#3114) (#3147) Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara enabled auto-merge (squash) July 3, 2024 08:25
Copy link

sonarqubecloud bot commented Jul 3, 2024

@MohamadJaara MohamadJaara merged commit 0f8ae93 into release/cycle-4.6 Jul 3, 2024
12 checks passed
@MohamadJaara MohamadJaara deleted the fix/asset-restriction-4.6 branch July 3, 2024 08:54
Copy link
Contributor

github-actions bot commented Jul 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants