Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherrypick privacy links and terms of use sections (WPB-8846) #3149

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 2, 2024

TaskWPB-8846 [Android] Add privacy policy and terms of use section to Android


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to cherry pick these changes for 4.6, since we need to implement them for private c1 and c3 builds.

Causes (Optional)

Not in scope initially

Solutions

Cherry pick, @alexandreferris 's work


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from alexandreferris, a team, MohamadJaara, vitorhugods, mchenani and Garzas and removed request for a team July 2, 2024 14:20
Copy link

sonarqubecloud bot commented Jul 2, 2024

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Test Results

855 tests   855 ✅  13m 22s ⏱️
117 suites    0 💤
117 files      0 ❌

Results for commit d1628bd.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina merged commit ddc4708 into release/cycle-4.6 Jul 2, 2024
13 checks passed
@yamilmedina yamilmedina deleted the feat/cherrypick-privacy-links branch July 2, 2024 15:09
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants