-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: errors in fdroid build script causeing it to build DevDebug instead of FdroidRelease #3060
Conversation
Quality Gate passedIssues Measures |
@@ -27,6 +27,7 @@ buildscript { | |||
classpath(libs.hilt.gradlePlugin) | |||
val fdroidBuild = (System.getenv("flavor") | |||
?: System.getenv("FLAVOR") | |||
?: System.getenv("CUSTOM_FLAVOR") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really document these in a BUILDING.md
file or similar.
So we could summarise all of the process not only for newcomers but for us. There might be room to simplify stuff but I can say from my side that it's a bit hard to wrap my head around all the env variables needed to make releases.
Test Results928 tests 928 ✅ 11m 16s ⏱️ Results for commit 8bfd24d. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5108 succeeded. The build produced the following APK's: |
…ead of FdroidRelease (#3060)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Solutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.