-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash when no browser available (WPB-9436) #3041
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3041 +/- ##
===========================================
- Coverage 44.26% 44.22% -0.04%
===========================================
Files 450 450
Lines 14513 14520 +7
Branches 2496 2496
===========================================
- Hits 6424 6422 -2
- Misses 7386 7395 +9
Partials 703 703
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5019 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
If the app has no browser available to handle opening a URL, the app crashes.
Solutions
For now, as discussed in https://wearezeta.atlassian.net/browse/WPB-9436?focusedCommentId=124984
We handle it and log it, there is no extra action needed for now.
How to Test
Disable and/or delete all browsers in the phone, before the app was crashing, now it just does nothing, but you can see logs for it either locally or in datadog.
Attachments (Optional)
Screen_Recording_20240527_165038_One.UI.Home.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.