Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group messages date | design changes (WPB-1733) 🍒 #2987

Merged
merged 2 commits into from
May 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2024

StoryWPB-1733 Timestamps – grouping functionality for dates

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Edge case when message is the first and only message
  • Edge case when its the last message
  • Design on divider margins

Solutions

  • Some design changes (margin on divider)
  • Addition of edge case when its only 1 message or the last message
  • Addition of 45min gap handling
  • Remove date from the right side of Message Item (instead of [date|time] -> [time])

Dependencies (Optional)

Needs releases with:

Screenshot 2024-05-06 at 12 00 33 Screenshot 2024-05-06 at 12 00 08

Signed-off-by: alexandreferris <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 8, 2024
@alexandreferris alexandreferris requested review from a team, yamilmedina, MohamadJaara, vitorhugods, mchenani and Garzas and removed request for a team May 8, 2024 08:14
@alexandreferris alexandreferris enabled auto-merge May 8, 2024 08:14
@alexandreferris alexandreferris added this pull request to the merge queue May 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 44.29%. Comparing base (377f600) to head (48f899d).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2987      +/-   ##
===========================================
+ Coverage    44.19%   44.29%   +0.09%     
===========================================
  Files          444      444              
  Lines        14476    14488      +12     
  Branches      2489     2492       +3     
===========================================
+ Hits          6398     6417      +19     
+ Misses        7386     7373      -13     
- Partials       692      698       +6     
Files Coverage Δ
...e/android/ui/home/conversations/model/UIMessage.kt 51.31% <0.00%> (-0.31%) ⬇️
.../main/kotlin/com/wire/android/util/DateTimeUtil.kt 69.09% <9.09%> (-6.15%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76c189...48f899d. Read the comment docs.

Copy link
Contributor Author

github-actions bot commented May 8, 2024

Test Results

927 tests   927 ✅  13m 41s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 48f899d.

Copy link
Contributor Author

github-actions bot commented May 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 1a4a439 May 8, 2024
11 of 12 checks passed
@alexandreferris alexandreferris deleted the fix/group_messages_date-cherry-pick branch May 8, 2024 09:14
@AndroidBob
Copy link
Collaborator

Build 4676 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants