Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve swipe detection and animation [WPB-9046] #2985

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented May 7, 2024

BugWPB-9046 [Android] Removing swipe to reply on certain screens


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Swipe was getting a bit in the way of the scrolling
  • Design suggested to centralise the reply swipe indicator to make it prettier

Solutions

For the swipe, just increasing the local slope configuration to make it easier to scroll.

For the animation, using AnchoredDraggableState instead of SwipeToDismissBox, as it allows finer control.

Attachments

The centralised icon positioning:

video_2024-05-07_18-18-37.mp4

The gesture "completion detection" happens when the user swipes one third of the screen.

So, when 1/3 of the screen is blue, the user can release it.
At that point, the icon will be at the centre of the blue area. If the user continues swiping, the icon will stay there, it's already enough, no need to keep dragging.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 7, 2024

Test Results

927 tests   927 ✅  13m 17s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 472f387.

Copy link
Contributor

github-actions bot commented May 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4667 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit f7e7f0e into release/candidate May 8, 2024
15 checks passed
@vitorhugods vitorhugods deleted the fix/improve-swipe-detection-and-animation branch May 8, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants