Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search message highlight [WPB-5163] #2426

Merged
merged 5 commits into from
Nov 15, 2023
Merged

feat: search message highlight [WPB-5163] #2426

merged 5 commits into from
Nov 15, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 15, 2023 •
edited by github-actions bot
Loading

StoryWPB-5163 Highlight search result that matches the input text

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • highlight searched messages by query text
  • trim search query and disable search for empty spaces

Attachments (Optional)

message_highlights.mp4

@Garzas Garzas requested review from alexandreferris and a team November 15, 2023 06:24
@Garzas Garzas self-assigned this Nov 15, 2023
@Garzas Garzas requested review from typfel, gongracr, yamilmedina and saleniuk and removed request for a team November 15, 2023 06:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

Test Results

682 tests  +2   682 ✔️ +2   9m 18s ⏱️ + 1m 8s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ❌ ±0 

Results for commit 3eda83a. ± Comparison against base commit 4a25e69.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1832 failed.

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Merging #2426 (3eda83a) into develop (4a25e69) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #2426      +/-   ##
=============================================
- Coverage      41.41%   41.40%   -0.02%     
- Complexity      1079     1084       +5     
=============================================
  Files            346      346              
  Lines          12513    12512       -1     
  Branches        1639     1638       -1     
=============================================
- Hits            5182     5180       -2     
- Misses          6846     6847       +1     
  Partials         485      485
Files Coverage Δ
...otlin/com/wire/android/util/QueryMatchExtractor.kt 100.00% <100.00%> (ø)
...ch/messages/SearchConversationMessagesViewModel.kt 82.50% <50.00%> (ø)
...in/kotlin/com/wire/android/ui/markdown/NodeData.kt 29.41% <0.00%> (-1.84%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a25e69...3eda83a. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1833 succeeded.

The build produced the following APK's:

alexandreferris
alexandreferris approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 👏🏻

mchenani
mchenani approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍳

@Garzas Garzas enabled auto-merge November 15, 2023 12:01
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1843 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Nov 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 18795b3 Nov 15, 2023
@Garzas Garzas deleted the feat/search-message-highlight branch November 15, 2023 13:55
@AndroidBob
Copy link
Collaborator

Build 1849 succeeded.

The build produced the following APK's:

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garzas @AndroidBob @yamilmedina @alexandreferris @mchenani