Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: legal hold UI - create all related dialogs [WPB-5446] #2421

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Nov 13, 2023

TaskWPB-5446 [Android] UI - create all dialogs related to legal hold


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In order to be able to inform about legal hold and all related changes, we need to have dialogs that show these informations to the user and ask for the approval or confirmation.

Solutions

Implement all dialogs related to the legal hold feature according to the designs.

Attachments (Optional)

image image image image image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Test Results

680 tests   680 ✔️  8m 25s ⏱️
  98 suites      0 💤
  98 files        0

Results for commit fdaac22.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1782 failed.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2421 (fdaac22) into develop (db858ea) will decrease coverage by 0.14%.
Report is 4 commits behind head on develop.
The diff coverage is 7.14%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2421      +/-   ##
=============================================
- Coverage      41.56%   41.42%   -0.14%     
+ Complexity      1084     1079       -5     
=============================================
  Files            344      346       +2     
  Lines          12471    12511      +40     
  Branches        1634     1639       +5     
=============================================
  Hits            5183     5183              
- Misses          6803     6843      +40     
  Partials         485      485              
Files Coverage Δ
...poser/attachments/IsFileSharingEnabledViewModel.kt 0.00% <0.00%> (ø)
...ui/home/conversations/CompositeMessageViewModel.kt 88.88% <60.00%> (-11.12%) ⬇️
...d/ui/connection/ConnectionActionButtonViewModel.kt 74.48% <11.11%> (+0.75%) ⬆️
...alhold/dialog/requested/LegalHoldRequestedState.kt 0.00% <0.00%> (ø)
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353bb69...fdaac22. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1783 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, alexandreferris, borichellow, MohamadJaara, vitorhugods and mchenani and removed request for a team November 14, 2023 12:33
Copy link
Member

@ohassine ohassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for more visibility, can we put dialogs under dialog package ?

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1817 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2023
@saleniuk saleniuk added this pull request to the merge queue Nov 14, 2023
Merged via the queue into develop with commit bc967ac Nov 14, 2023
11 checks passed
@saleniuk saleniuk deleted the feat/legal-hold-dialogs branch November 14, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants