Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: white screen after splash screen (WPB-5439) #2417

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 13, 2023

BugWPB-5439 White screen after splash screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On cold startup, the app is showing a white screen for some seconds after splash screen.

Causes (Optional)

Splash API limitation

Solutions

Keep showing the splash screen until the app is drawn

Needs releases with:

  • GitHub link to other pull request

Testing

How to Test

  • Start the app on cold startup
  • you should not see white screen after splash

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, gongracr, yamilmedina, mchenani and saleniuk and removed request for a team November 13, 2023 09:04
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2417 (8136756) into develop (c503b72) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2417      +/-   ##
=============================================
- Coverage      41.48%   41.47%   -0.02%     
  Complexity      1085     1085              
=============================================
  Files            344      344              
  Lines          12430    12433       +3     
  Branches        1632     1632              
=============================================
  Hits            5157     5157              
- Misses          6788     6791       +3     
  Partials         485      485              
Files Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c503b72...8136756. Read the comment docs.

Copy link
Contributor

Test Results

680 tests  ±0   680 ✔️ ±0   8m 3s ⏱️ - 2m 58s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit 8136756. ± Comparison against base commit c503b72.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1760 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Nov 14, 2023
Merged via the queue into develop with commit 12a31d6 Nov 14, 2023
@ohassine ohassine deleted the white_screen_after_splash branch November 14, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants