fix: Conversation verification changed message showing #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
alexandreferris,
MohamadJaara,
vitorhugods,
Garzas and
saleniuk
alexandreferris
approved these changes
Nov 10, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1741 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1745 succeeded. The build produced the following APK's: |
saleniuk
approved these changes
Nov 13, 2023
borichellow
deleted the
fix/conversation_verification_changed_message_showing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
when conversation verification was changed, system message about if was showing only after re-opening the conversation OR if some other message was added to DB.
Causes (Optional)
System message about Proteus verification changes is added in DB layer by Trigger. This means it doesn't inform observers about changes in conversation (in DAO layer).
AND
Flow of messages in conversation was cached in ViewModel scope.
Solutions
Remove caching Flow of messages in ViewModel scope, so when user comes back to messages list from conversation details, he'll see a fresh list.
P.S. This shouldn't affect performance.