feat: Search inside conversation (WPB-4915) #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatus from message
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsScreen.kt
alexandreferris
requested review from
vitorhugods,
ohassine,
saleniuk and
yamilmedina
yamilmedina
reviewed
Oct 23, 2023
...e/android/ui/home/conversations/search/messages/SearchConversationMessagesNoResultsScreen.kt
Show resolved
Hide resolved
...n/com/wire/android/ui/home/conversations/search/messages/SearchConversationMessagesScreen.kt
Show resolved
Hide resolved
...in/com/wire/android/ui/home/conversations/search/messages/SearchConversationMessagesState.kt
Outdated
Show resolved
Hide resolved
...n/com/wire/android/ui/home/conversations/messages/SearchConversationMessagesViewModelTest.kt
Outdated
Show resolved
Hide resolved
yamilmedina
approved these changes
Oct 23, 2023
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 1465 succeeded. The build produced the following APK's: |
vitorhugods
requested changes
Oct 23, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageItem.kt
Outdated
Show resolved
Hide resolved
|
APKs built during tests are available here. Scroll down to Artifacts! |
vitorhugods
approved these changes
Oct 23, 2023
|
Build 1471 succeeded. The build produced the following APK's: |
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
No way to search messages from a conversation.
Causes (Optional)
Not implemented.
Solutions
Addition of screen to search messages of selected conversation.
Entry points:
There is a minimum of 2 characters to start the search and a debounce of 500ms in between each search.
This PR aims only to display the searched messages and not being able to select a message and navigate to its place in Conversation screen.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Attachments (Optional)