Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issue not activating search on long click in search bar [WPB-2231] #2353

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Oct 20, 2023

BugWPB-2231 Longclick on magnifier Icon activates search, but search is not possible


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was an issue with TopSearchBar which basically was preventing the isSearchActive flag to be updated whenever a long tap event was happening on the leading magnifying icon, hence forwarding the long tap event to the inner text field.

Solutions

@saleniuk had the great idea of adding an extra invisible box on top of the search bar, only present when search is not active, that will intercept and discard the long click events, and open the search for normal ones.

Attachments

Grabacion.de.pantalla.2023-10-20.a.las.13.18.44.mov

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

649 tests  ±0   649 ✔️ ±0   4m 49s ⏱️ - 5m 2s
  94 suites ±0       0 💤 ±0 
  94 files   ±0       0 ±0 

Results for commit 72ebfec. ± Comparison against base commit 37ec8f1.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1445 succeeded.

The build produced the following APK's:

@gongracr gongracr enabled auto-merge October 20, 2023 13:43
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gongracr gongracr added this pull request to the merge queue Oct 20, 2023
Merged via the queue into develop with commit fe73263 Oct 20, 2023
13 checks passed
@gongracr gongracr deleted the fix/long_tap_searchbar_issue branch October 20, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants