fix: fixed issue not activating search on long click in search bar [WPB-2231] #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
There was an issue with
TopSearchBar
which basically was preventing theisSearchActive
flag to be updated whenever a long tap event was happening on the leading magnifying icon, hence forwarding the long tap event to the inner text field.Solutions
@saleniuk had the great idea of adding an extra invisible box on top of the search bar, only present when search is not active, that will intercept and discard the long click events, and open the search for normal ones.
Attachments
Grabacion.de.pantalla.2023-10-20.a.las.13.18.44.mov
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.