fix(links): embedded links with escaped chars [e.g. plus] (WPB-4402)

[mchenani]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

When the embedded link in a message, was encoded with escape chars such as +, we were decoding it unnecessary and that was causing an error in detecting the url as invalid one, in the result we were adding an extra schema [https] to the valid link.

Issues

Adding an extra schema [https] to the valid link with escape chars.

Causes (Optional)

Unneeded decoding.

Solutions

Removed the unneeded decoding, and adding more tests.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Have an embedded link like: https://google.com/this+is+a+test, the link the app tried to open should be the same and with only one https.

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 1395 succeeded.

The build produced the following APK's:

• com.wire.android-v4.4.0(7865899)(7865899)-staging-compat.apk