Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove github packages repository WPB-5028 #2337

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 17, 2023

StoryWPB-5028 upload core-crypto-multiplatform to sonatype via automation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Remove Github Packages repository since all dependencies are now on maven central.

Dependencies

Needs releases with:


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel typfel requested review from a team, gongracr, yamilmedina, borichellow, Garzas and ohassine and removed request for a team October 17, 2023 12:30
@typfel typfel changed the title chore: remove github packages repository chore: remove github packages repository WPB-5028 Oct 17, 2023
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can also be removed from the README.md :)

Awesome, awesome job :)

Great step!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Test Results

649 tests  ±0   649 ✔️ ±0   8m 12s ⏱️ + 2m 46s
  94 suites ±0       0 💤 ±0 
  94 files   ±0       0 ±0 

Results for commit e5a7455. ± Comparison against base commit 3eeea52.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1362 succeeded.

The build produced the following APK's:

@typfel typfel force-pushed the chore/remove-github-packages branch from e86b2af to e5a7455 Compare October 17, 2023 20:16
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2337 (e86b2af) into develop (3eeea52) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e86b2af differs from pull request most recent head e5a7455. Consider uploading reports for the commit e5a7455 to get more accurate results

@@            Coverage Diff             @@
##             develop    #2337   +/-   ##
==========================================
  Coverage      41.24%   41.25%           
  Complexity      1058     1058           
==========================================
  Files            332      331    -1     
  Lines          12032    12031    -1     
  Branches        1594     1596    +2     
==========================================
  Hits            4963     4963           
+ Misses          6594     6593    -1     
  Partials         475      475           

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eeea52...e5a7455. Read the comment docs.

@typfel
Copy link
Member Author

typfel commented Oct 17, 2023

I guess it can also be removed from the README.md :)

Awesome, awesome job :)

Great step!

Updated the README (in kalium)

@typfel typfel enabled auto-merge October 17, 2023 20:18
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1385 succeeded.

The build produced the following APK's:

@typfel typfel requested a review from vitorhugods October 18, 2023 07:44
@typfel typfel added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit 4bcd746 Oct 18, 2023
10 checks passed
@typfel typfel deleted the chore/remove-github-packages branch October 18, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants