Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2ei): add e2ei certificate manual enrollment (WPB-309) #1840

Merged
merged 50 commits into from
Nov 17, 2023
Merged

feat(e2ei): add e2ei certificate manual enrollment (WPB-309) #1840

merged 50 commits into from
Nov 17, 2023

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented Jun 6, 2023 •
edited by github-actions bot
Loading

EpicWPB-309 [AR] E2EI Manually issue certificate

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add google OAuth and E2EI manual enrolment in debug screen.

Testing

WIP

How to Test

  • Against MLS Enabled backend
  • Have you account added to the Wire-E2EI OAuth test server
  • You should be able to enrol the E2EI Certificate and before that you must authorise OAuth via GoogleOAuth.

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani added WIP Work In Progress DO NOT MERGE labels Jun 6, 2023
@mchenani mchenani requested review from typfel and MohamadJaara June 6, 2023 07:12
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AndroidBob
Copy link
Collaborator

Build 1 failed.

@AndroidBob
Copy link
Collaborator

Build 2 failed.

@AndroidBob
Copy link
Collaborator

Build 3 failed.

@AndroidBob
Copy link
Collaborator

Build 4 failed.

@AndroidBob
Copy link
Collaborator

Build 5 failed.

mchenani added 2 commits June 15, 2023 09:23
@mchenani
Merge branch 'develop' of https://github.com/wireapp/wire-android-rel…
862c78a 
…oaded into feat/e2ei/manual_e2ei_certificate_enrolment

� Conflicts:
�	app/src/main/kotlin/com/wire/android/ui/debug/dev/DevDebugContent.kt
�	app/src/main/kotlin/com/wire/android/ui/debug/dev/DevDebugViewModel.kt
�	app/src/main/res/values/strings.xml
@mchenani
add certificate dialog
daafe26
@AndroidBob
Copy link
Collaborator

Build 6 failed.

@AndroidBob
Copy link
Collaborator

Build 7 failed.

@AndroidBob
Copy link
Collaborator

Build 130 failed.

@AndroidBob
Copy link
Collaborator

Build 131 failed.

@mchenani mchenani requested a review from borichellow June 28, 2023 10:05
@AndroidBob
Copy link
Collaborator

Build 1786 failed.

@AndroidBob
Copy link
Collaborator

Build 1787 failed.

@AndroidBob
Copy link
Collaborator

Build 1807 failed.

@AndroidBob
Copy link
Collaborator

Build 1816 failed.

@AndroidBob
Copy link
Collaborator

Build 1818 failed.

@AndroidBob
Copy link
Collaborator

Build 1825 failed.

@AndroidBob
Copy link
Collaborator

Build 1834 failed.

@AndroidBob
Copy link
Collaborator

Build 1835 failed.

@AndroidBob
Copy link
Collaborator

Build 1879 failed.

@mchenani mchenani enabled auto-merge November 17, 2023 15:49
@mchenani mchenani added this pull request to the merge queue Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit f818ed4 Nov 17, 2023
10 checks passed
@mchenani mchenani deleted the feat/e2ei/manual_e2ei_certificate_enrolment branch November 17, 2023 16:18
@AndroidBob
Copy link
Collaborator

Build 1881 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@borichellow borichellow borichellow approved these changes

@typfel typfel Awaiting requested review from typfel

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@mchenani mchenani

Labels
DO NOT MERGE size/L WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mchenani @CLAassistant @AndroidBob @borichellow @Garzas