fix: remove browser allow list and skip of https check (WPB-6609) (#2714

) Co-authored-by: Alexandre Ferris <[email protected]>
wireapp · Feb 16, 2024 · a2e16ee · a2e16ee
1 parent ca11930
commit a2e16ee
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt b/app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt
@@ -39,8 +39,6 @@ import net.openid.appauth.AuthorizationService
 import net.openid.appauth.AuthorizationServiceConfiguration
 import net.openid.appauth.ClientAuthentication
 import net.openid.appauth.ResponseTypeValues
-import net.openid.appauth.browser.BrowserAllowList
-import net.openid.appauth.browser.VersionedBrowserMatcher
 import org.json.JSONObject
 import java.net.URI
 import java.security.MessageDigest
@@ -60,13 +58,6 @@ class OAuthUseCase(
     private lateinit var authServiceConfig: AuthorizationServiceConfiguration
 
     private var appAuthConfiguration: AppAuthConfiguration = AppAuthConfiguration.Builder()
-        .setBrowserMatcher(
-            BrowserAllowList(
-                VersionedBrowserMatcher.CHROME_CUSTOM_TAB,
-                VersionedBrowserMatcher.SAMSUNG_CUSTOM_TAB
-            )
-        )
-        .setSkipIssuerHttpsCheck(true)
         .build()
 
     init {

diff --git a/kalium b/kalium
+1 −1		logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
+10 −3		network/src/androidMain/kotlin/com/wire/kalium/network/OkhttpClientFactory.kt
+13 −3		network/src/androidUnitTest/kotlin/com/wire/kalium/api/tools/HttpClientConnectionSpecsTest.kt
+2 −0		network/src/appleMain/kotlin/com/wire/kalium/network/defaultHttpEngine.kt
+8 −2		network/src/commonJvmAndroid/kotlin/com/wire/kalium/network/HttpEngine.kt
+2 −0		network/src/commonMain/kotlin/com/wire/kalium/network/HttpEngine.kt
+11 −6		network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEApi.kt
+35 −2		network/src/commonMain/kotlin/com/wire/kalium/network/networkContainer/UnboundNetworkContainer.kt
+7 −9		network/src/commonTest/kotlin/com/wire/kalium/api/common/ACMEApiTest.kt
+8 −2		network/src/jvmMain/kotlin/com/wire/kalium/network/OkhttpClientFactory.kt
+12 −3		network/src/jvmTest/kotlin/com/wire/kalium/HttpClientConnectionSpecsTest.kt