chore(tests): support vintage engine (junit4) and add robolectric (AC…

…OL-139) (#2662)
wireapp · Feb 6, 2024 · 1889535 · 1889535
1 parent fe78d52
commit 1889535
Show file tree

Hide file tree

Showing 7 changed files with 262 additions and 140 deletions.
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -164,6 +164,8 @@ dependencies {
     testImplementation(libs.kluent.core)
     testImplementation(libs.turbine)
     testImplementation(libs.okio.fakeFileSystem)
+    testImplementation(libs.robolectric)
+    testRuntimeOnly(libs.junit5.vintage.engine)
     testRuntimeOnly(libs.junit5.engine)
     testImplementation(libs.androidx.paging.testing)
 

diff --git a/...om/wire/android/ui/home/conversations/details/editguestaccess/EditGuestAccessViewModel.kt b/...om/wire/android/ui/home/conversations/details/editguestaccess/EditGuestAccessViewModel.kt
@@ -174,7 +174,11 @@ class EditGuestAccessViewModel @Inject constructor(
                         )
                     )
 
-                    is UpdateConversationAccessRoleUseCase.Result.Success -> Unit
+                    is UpdateConversationAccessRoleUseCase.Result.Success -> updateState(
+                        editGuestAccessState.copy(
+                            isGuestAccessAllowed = shouldEnableGuestAccess
+                        )
+                    )
                 }
                 updateState(editGuestAccessState.copy(isUpdatingGuestAccess = false))
             }

diff --git a/app/src/test/kotlin/com/wire/android/mapper/UserTypeMapperTest.kt b/app/src/test/kotlin/com/wire/android/mapper/UserTypeMapperTest.kt
@@ -21,7 +21,7 @@ package com.wire.android.mapper
 import com.wire.android.ui.home.conversationslist.model.Membership
 import com.wire.kalium.logic.data.user.type.UserType
 import org.amshove.kluent.internal.assertEquals
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class UserTypeMapperTest {
 
@@ -48,7 +48,7 @@ class UserTypeMapperTest {
     @Test
     fun `given internal as a user type correctly map to none as membership`() {
         val result = userTypeMapper.toMembership(UserType.INTERNAL)
-        assertEquals(Membership.None, result)
+        assertEquals(Membership.Standard, result)
     }
 
 }
diff --git a/app/src/test/kotlin/com/wire/android/migration/MigrationMapperTest.kt b/app/src/test/kotlin/com/wire/android/migration/MigrationMapperTest.kt
@@ -21,14 +21,15 @@ import com.wire.android.config.CoroutineTestExtension
 import com.wire.kalium.logic.data.id.QualifiedID
 import com.wire.kalium.logic.data.user.UserId
 import org.amshove.kluent.internal.assertEquals
-import org.junit.Test
 import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
 
 @ExtendWith(CoroutineTestExtension::class)
 class MigrationMapperTest {
 
     private lateinit var migrationMapper: MigrationMapper
+
     @BeforeEach
     fun setUp() {
         migrationMapper = MigrationMapper()